-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
range() function #2058
range() function #2058
Conversation
aada2e2
to
8a27af1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2058 +/- ##
==========================================
- Coverage 90.23% 90.21% -0.03%
==========================================
Files 950 953 +3
Lines 33779 34582 +803
==========================================
+ Hits 30480 31197 +717
- Misses 3299 3385 +86
☔ View full report in Codecov by Sentry. |
@@ -35,6 +35,7 @@ const std::string CAST_TO_BLOB_FUNC_NAME = "BLOB"; | |||
|
|||
// list | |||
const std::string LIST_CREATION_FUNC_NAME = "LIST_CREATION"; | |||
const std::string LIST_RANGE_FUNC_NAME = "RANGE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR but I guess we can start sorting these function names in alphabetical order. Also sort code when you register.
de7fca1
to
53e605e
Compare
range(start, end, step)
produces[start, start + step, ..., end]